Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use card suffix for manage screen title when customer only has saved cards. #10490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Mar 25, 2025

Summary

Use card suffix for manage screen title when customer only has saved cards.

Note: Don't merge until translations are available!

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2889

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe
Copy link
Collaborator Author

Opening for review but not going to merge until we get the translations back.

Copy link
Contributor

github-actions bot commented Mar 25, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.4 KiB │   7.4 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ -3 B │ 182.4 KiB │ 182.4 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -3 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20144 │ 20144 │ 0 (+0 -0) 
   types │  6235 │  6235 │ 0 (+0 -0) 
 classes │  5026 │  5026 │ 0 (+0 -0) 
 methods │ 30045 │ 30045 │ 0 (+0 -0) 
  fields │ 17388 │ 17388 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3644 │ 3644 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
   29 KiB │ -4 B │   64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ +2 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 30.4 KiB │ -3 B │ 65.4 KiB │  0 B │ (total)

@samer-stripe samer-stripe force-pushed the samer/manage-screen-title-for-cards branch from 0801210 to 89b5795 Compare March 25, 2025 18:52
@samer-stripe samer-stripe marked this pull request as ready for review March 25, 2025 20:25
@samer-stripe samer-stripe requested review from a team as code owners March 25, 2025 20:25
}
}

private val manageTitle: ResolvableString
get() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use getter for all kinds of title? isEditing and containsOnlyCards do not seem changeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants