Support Expiration Date Changes #10568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEX |
toluo-stripe
force-pushed
the
tolu/uspm/card_edit_handler_expiryDate
branch
2 times, most recently
from
41d38df to
0d35066
Compare
toluo-stripe
changed the title
toluo-stripe
force-pushed
the
tolu/uspm/card_edit_handler_expiryDate
branch
from
0d35066 to
6742926
Compare
toluo-stripe
force-pushed
the
tolu/uspm/card_edit_handler_expiryDate
branch
from
f648308 to
905245b
Compare
samer-stripe
reviewed
Apr 8, 2025
| val availableNetworks: List<CardBrandChoice> | ||
| val expiryDateEditEnabled: Boolean, | ||
| val availableNetworks: List<CardBrandChoice>, | ||
| val dateValidator: (String) -> TextFieldState |
There was a problem hiding this comment.
I'd prefer if we avoid passing functions through the state unless necessary. Validating the date within the UI feels like the wrong solution.
samer-stripe
reviewed
Apr 8, 2025
| @@ -9,6 +10,8 @@ import com.stripe.android.paymentsheet.CardUpdateParams | |||
| */ | |||
| internal data class CardDetailsEntry( | |||
| val cardBrandChoice: CardBrandChoice, | |||
| val expMonth: Int? = null, | |||
| val expYear: Int? = null, | |||
There was a problem hiding this comment.
Rather than nullable parameters, can we make a ExpiryDateState that encompassed the DateConfig? You build something similar for Cvc Recollection for CvcState that I think works better.
samer-stripe
reviewed
Apr 8, 2025
| expMonth = map[IdentifierSpec.CardExpMonth]?.value?.toIntOrNull()?.takeIf { it > 0 }, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
From the comment above, can the state itself parse out the string and digest this?
# Conflicts: # paymentsheet/src/test/java/com/stripe/android/model/PaymentMethodFixtures.kt
� Conflicts: � paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/EditCardDetailsInteractor.kt � paymentsheet/src/test/java/com/stripe/android/paymentsheet/ui/DefaultEditCardDetailsInteractorTest.kt
Update EditCardDetailsInteractor.kt Remove callback from interface rename factory Update UpdatePaymentMethodInteractor.kt Update UpdatePaymentMethodInteractor.kt Update FakeEditCardDetailsInteractor.kt Refactor factory Fix tests Update UpdatePaymentMethodInteractor.kt Fix tests Fix factory Update FakeEditCardDetailsInteractor.kt Update DefaultEditCardDetailsInteractorTest.kt temp more tests
Update ExpiryDateState.kt
toluo-stripe
force-pushed
the
tolu/uspm/card_edit_handler_expiryDate
branch
from
3cef83e to
a6b1cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support expiry date changes. This feature is controlled by a local feature flag.
Motivation
JIRA
Testing
Screenshots
Screen.Recording.2025-04-07.at.12.22.37.PM.mov
Changelog