Setup AnalyticEventCallbackRule for DefaultEventReporterTest

[cttsai-stripe]

Summary

Use a TestWatcher to wrap up the callback provider initialization and the turbine clean up.

Motivation

To prevent duplicate callback initializing when adding more tests

Testing

• Added tests
• Modified tests
• Manually verified

[cttsai-stripe]

I was trying to share the test rule for both DefaultEventReporterTest(unit test) and other analytics tests (android test). If I place the rule to somewhere they all can access like payments-core-testing, then AnalyticEventCallback can not be accessed by the rule. It seems that I can only write two rules for the test separately.

[cttsai-stripe]

I am not sure which one is better. Or should we use both?

[jaynewstrom-stripe]

This is the correct one.

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.3 KiB │   7.3 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ +6 B │ 182.4 KiB │ 182.4 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +6 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20142 │ 20142 │ 0 (+0 -0) 
   types │  6235 │  6235 │ 0 (+0 -0) 
 classes │  5026 │  5026 │ 0 (+0 -0) 
 methods │ 30047 │ 30047 │ 0 (+0 -0) 
  fields │ 17385 │ 17385 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3644 │ 3644 │  0

APK

   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.7 KiB │ +4 B │    64 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
   29 KiB │ +3 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼───────────┼──────┼────────────────────────
 55.8 KiB │ +6 B │ 129.3 KiB │  0 B │ (total)

[jaynewstrom-stripe]

Should the nulling it out happen automatically?

[cttsai-stripe]

No, the default is to receive the event. The AnalyticEventCallbackRule will set the turbine as the default callback at the beginning of the tests and null them after finishing. This setting is reasonable to me because this reduce boilerplate code when testing all nine kinds of events.

[jaynewstrom-stripe]

What's the use case for this? It seems kinda confusing that it can be set in two different ways?

[cttsai-stripe]

This is for setting non default callbacks, e.g. null callback or throwing errors. I think wrapping this as a function looks more like the callback builder in the production code. I can remove this setter and make the callback member variable public if that is better.

It seems kinda confusing that it can be set in two different ways?

I think there is only one setter exposed for this class?