Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset() from PaymentSheet #4734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Mar 27, 2025

Summary

  • Removed reset in favor of resetCustomer
  • Don't see any mention of it in the docs

Motivation

https://docs.google.com/document/d/1DVnqjz5gLAP_JbjxZJ0Ptdv72hO0jTfreYx6_CdcGn0/edit?tab=t.0

Testing

  • Compiler

Changelog

See diff

Copy link

github-actions bot commented Mar 27, 2025

⚠️ Public API changes detected:

StripePaymentSheet

- @available(*, deprecated, renamed: "resetCustomer()")
- public static func reset()

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant