Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace optional NSNumber with Bool #4735

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

porter-stripe
Copy link
Collaborator

@porter-stripe porter-stripe commented Mar 27, 2025

Summary

Motivation

  • v25

Testing

  • CI

Changelog

@porter-stripe porter-stripe changed the title Add STPPaymentMethod type array to PI and SI Replace optional NSNumber with Bool Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

⚠️ Public API changes detected:

StripePayments

- public let paymentMethodTypes: [Foundation.NSNumber]
- public var paymentMethodTypes_objc: [Foundation.NSNumber] {
+ @objc get
+ }
- public let paymentMethodTypes: [StripePayments.STPPaymentMethodType]
- public var savePaymentMethod: Foundation.NSNumber?
- public var savePaymentMethod_objc: Foundation.NSNumber? {
+ @objc get
+ @objc set
+ }
- public var savePaymentMethod: Swift.Bool
- @available(*, deprecated, renamed: "savePaymentMethod")
- public var saveSourceToCustomer: Foundation.NSNumber? {
- @objc get
- @objc set(saveSourceToCustomer)
- }
- public var directorsProvided: Foundation.NSNumber?
- public var directorsProvided_objc: Foundation.NSNumber? {
+ @objc get
+ @objc set
+ }
- public var directorsProvided: Swift.Bool
- public var ownersProvided: Foundation.NSNumber?
- public var ownersProvided_objc: Foundation.NSNumber? {
+ @objc get
+ @objc set
+ }
- public var ownersProvided: Swift.Bool
- public var tosShownAndAccepted: Foundation.NSNumber?
- public var tosShownAndAccepted_objc: Foundation.NSNumber? {
+ @objc get
+ @objc set
+ }
- public var tosShownAndAccepted: Swift.Bool
- public let paymentMethodTypes: [Foundation.NSNumber]
- public var paymentMethodTypes_objc: [Foundation.NSNumber] {
+ @objc get
+ }
- public let paymentMethodTypes: [StripePayments.STPPaymentMethodType]
- public var useStripeSDK: Foundation.NSNumber?
- public var useStripeSDK_objc: Foundation.NSNumber? {
+ @objc get
+ @objc set
+ }
- public var useStripeSDK: Swift.Bool

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant