Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation jank when removing the last payment method in vertical #4743

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

joyceqin-stripe
Copy link
Collaborator

Summary

When removing the last payment method, show the payment method fading out before returning to the main screen instead of popping the update screen and manage screen in quick succession.

Motivation

MOBILESDK-2839

Testing

  • Manually

Before:

Simulator.Screen.Recording.-.iPhone.16.-.2025-03-28.at.11.45.29.mp4

After:

Simulator.Screen.Recording.-.iPhone.16.-.2025-03-28.at.14.04.05.mp4

Changelog

N/A

Copy link

github-actions bot commented Mar 28, 2025

🚨 New dead code detected in this PR:

FCLiteManifest.swift:31 warning: Initializer 'init(id:hostedAuthURL:successURL:cancelURL:product:manualEntryUsesMicrodeposits:)' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

Copy link

⚠️ Public API changes detected:

StripePaymentSheet

- public var link: StripePaymentSheet.PaymentSheet.LinkConfiguration
- public struct LinkConfiguration {
- public var display: StripePaymentSheet.PaymentSheet.LinkConfiguration.Display
- public enum Display : Swift.String {
- case automatic
- case never
- public init?(rawValue: Swift.String)
- public typealias RawValue = Swift.String
- public var rawValue: Swift.String {
- get
- }
- }
- public init(display: StripePaymentSheet.PaymentSheet.LinkConfiguration.Display = .automatic)
- }

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@joyceqin-stripe joyceqin-stripe marked this pull request as ready for review March 28, 2025 22:24
@joyceqin-stripe joyceqin-stripe requested review from a team as code owners March 28, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant