Update Afterpay logos for iOS users

[joyceqin-stripe]

Summary

Rebrand Afterpay in USD to be Cash App Afterpay, update shouldUseClearpayBrand to be determined by currency GBP

Motivation

https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3987

Testing

• Manually
• Updated snapshot tests
• Added snapshot tests

Cash App Afterpay:

Regular Afterpay:

Clearpay Afterpay:

Changelog

[Changed] Updated Afterpay branding in the US to be Cash App Afterpay.

[porter-stripe]

This doesn't look quite right, why is it shifted half way down?

[joyceqin-stripe]

I don't know why it shows up like that, but if you switch to viewing the source diff and back to rich diff it shows up correctly

[porter-stripe]

I think the spacing is a little off, probably need an extra space after " ".

Also the info icon in dark mode is hidden.

[joyceqin-stripe]

In order to add the space before Cash App Afterpay but not Afterpay or Clearpay, we'd need to add a special case— do you think it's needed? Also, the info icon is there but not easily seen because we don't have a white asset for it. Do you know how to get that?

[porter-stripe]

IMO I think the Afterpay and Clearpay could use a space too.

To get the info icon to be white, you could try to do what is done in traitCollectionDidChange and set the tint color.

[joyceqin-stripe]

The info icon is a part of a NSAttributedString— I'm not sure how to access the info icon from traitCollectionDidChange

[porter-stripe]

Hmm, did you try?

You can do this by:

1. Updating attributedStringOfImageWithoutLink to allow setting a tint color of the image attachment.

private func attributedStringOfImageWithoutLink(uiImage: UIImage, font: UIFont, tintColor: UIColor?) -> NSAttributedString {
    let imageAttachment = NSTextAttachment()
    imageAttachment.bounds = boundsOfImage(font: font, uiImage: uiImage)
    if let tintColor {
        imageAttachment.image = uiImage.withTintColor(tintColor, renderingMode: .alwaysTemplate)
    } else {
        imageAttachment.image = uiImage
    }
    return NSAttributedString(attachment: imageAttachment)
}

2. Update how we build the infoButton in makeAfterPayClearPayString():

let infoButton = attributedStringOfImageWithoutLink(uiImage: infoImage, font: titleFont, tintColor: theme.colors.parentBackground.contrastingColor)

3. Update traitCollectionDidChange to recompute the attributed string:

override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
    super.traitCollectionDidChange(previousTraitCollection)
    afterpayMarkImageView.tintColor = theme.colors.parentBackground.contrastingColor
    afterPayClearPayLabel.attributedText = makeAfterPayClearPayString()
}

[joyceqin-stripe]

I added a white info icon svg by editing the svg file

[porter-stripe]

Switching between the black and white logo seems fine, but there are some cases where this won't work! Imagine a case where a user is using the Appearance API to force their app into light mode (e.g., their app doesn't support dark mode). Then when the device is in dark mode, their app is in light mode. In this scenario, our info icon would be white and not visible.

Instead of using white for dark mode and black for light mode, we need to tint the image based on the color it is sitting on top of. The suggestion above does this, similar to how the afterpayMarkImageView does this.

[porter-stripe]

This needed?

[porter-stripe]

To avoid all these changes that aren't really needed, let's make currency default to nil in makeImage. That way you don't need to update many unrelated files. Once you add the default then you can come back to usages like this and revert the changes made.

[porter-stripe]

Why aren't we passing in currency here and instead nil even though we have a currency in scope?

[joyceqin-stripe]

Currency isn't needed for external payment types, but I guess there's no harm in passing it anyways

[porter-stripe]

Why do we need to pass currency into update, don't we have one in scope on self?

[github-actions]

⚠️ Missing Translations
The following strings have been uploaded to Lokalise but are not yet translated.

Buy now or pay later with

If it's okay for these strings to be unlocalized in master (e.g. this is for an unshipped feature), add the label ship without translations to acknowledge that there are missing translations. Otherwise, wait until translations are available in Lokalise and re-run this job.

New strings are localized on a weekly basis and are downloaded as part of the release process. For more details on how to localize a string, you can refer to this link.