Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix; ubuntu 24 toolchain #1900

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Note: this is only compatible with Linux runners.

name: Test setup
name: Setup
description: "Setup the environment for the CI"
inputs:
pull_token:
description: "Token to use for private repo access"
Expand Down Expand Up @@ -101,6 +102,3 @@ runs:
else
echo "pkg-config and libssl-dev are already installed."
fi
- name: Set up Docker
uses: docker/setup-buildx-action@v3
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:

check:
name: Cargo Check
runs-on: [runs-on, runner=16cpu-linux-x64, disk=medium, "run-id=${{ github.run_id }}"]
runs-on: [runs-on, runner=16cpu-linux-x64, disk=large, "run-id=${{ github.run_id }}"]
env:
CARGO_NET_GIT_FETCH_WITH_CLI: "true"
steps:
Expand Down Expand Up @@ -248,7 +248,7 @@ jobs:

- name: Run cargo prove new
run: |
cargo prove new fibonacci --version dev --evm
cargo prove new fibonacci --evm --version dev

- name: Build program and run script
run: |
Expand Down
21 changes: 20 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,25 @@ changes that are split across multiple commits.
That said, if you have a number of commits that are "checkpoints" and don't represent a single logical change, please
squash those together.

**Conventional Commit Messages and PR Titles:**
To ensure consistency and aid in automated tooling (such as changelog generation), please follow the
[Conventional Commits](https://www.conventionalcommits.org/) style for commit messages and PR titles. Prefix your commit
messages and PR titles with one of the following types:

- **feat:** for new features
- **fix:** for bug fixes
- **docs:** for documentation-only changes
- **refactor:** for code changes that neither fix a bug nor add a feature
- **chore:** for changes to the build process or auxiliary tools
- **test:** for adding or updating tests

For example:
- `docs: Update README with corrected links`
- `fix: Resolve race condition in event loop`

If your pull request title does not contain a valid prefix, automated checks may fail. You can amend your commit and
force-push to correct this before merging.

#### Opening the pull request

From within GitHub, opening a new pull request will present you with a template that should be filled out. Please try
Expand Down Expand Up @@ -162,4 +181,4 @@ _Adapted from the [Reth contributing guide](https://raw.githubusercontent.com/pa

[mcve]: https://stackoverflow.com/help/mcve

[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Loading
Loading