-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update(api): Update get all release api #38
Conversation
Dear @its-sushant, thanks for your contibution! Would you mind adding an entry about the feature you added also to ChangeLog.md? And if you're at it, you might also want to consider adding the good explanation you provided in #37 to the commit comment? |
By the way, do you know when this feature was added to SW360? I quickly checked in https://github.com/eclipse-sw360/sw360/blob/main/CHANGELOG.md, but couldn't find it at a first glance - might be helpful to also add this bit to the ChangeLog so users know if it's available or not. |
Ok, found eclipse-sw360/sw360#2657, so I guess it's expected to be part of SW360 19.1, right? |
Hi @its-sushant, |
91a8c7a
to
be0154c
Compare
Thank you @tngraf. I have added the unit test for the parameter. |
Thank You @gernot-h for the review. I have updated the changelog for this PR and also updated the commit message. |
Yes, I guess. |
Thanks, @its-sushant, for addressing my comments! Change looks good to me now, I also triggered the unit tests, so @tngraf can merge if he agrees… |
Thanks, @its-sushant, @gernot-h, @deveaud-m |
Fix: #37
CC: @deveaud-m