Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update(api): Update get all release api #38

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

its-sushant
Copy link
Contributor

Fix: #37
CC: @deveaud-m

@gernot-h
Copy link
Collaborator

gernot-h commented Nov 21, 2024

Dear @its-sushant, thanks for your contibution! Would you mind adding an entry about the feature you added also to ChangeLog.md? And if you're at it, you might also want to consider adding the good explanation you provided in #37 to the commit comment?

@gernot-h
Copy link
Collaborator

By the way, do you know when this feature was added to SW360? I quickly checked in https://github.com/eclipse-sw360/sw360/blob/main/CHANGELOG.md, but couldn't find it at a first glance - might be helpful to also add this bit to the ChangeLog so users know if it's available or not.

@gernot-h
Copy link
Collaborator

By the way, do you know when this feature was added to SW360? I quickly checked in https://github.com/eclipse-sw360/sw360/blob/main/CHANGELOG.md, but couldn't find it at a first glance - might be helpful to also add this bit to the ChangeLog so users know if it's available or not.

Ok, found eclipse-sw360/sw360#2657, so I guess it's expected to be part of SW360 19.1, right?

@tngraf
Copy link
Collaborator

tngraf commented Nov 21, 2024

Hi @its-sushant,
you also may want to add a unit test.

@its-sushant
Copy link
Contributor Author

Hi @its-sushant, you also may want to add a unit test.

Thank you @tngraf. I have added the unit test for the parameter.

@its-sushant
Copy link
Contributor Author

Dear @its-sushant, thanks for your contibution! Would you mind adding an entry about the feature you added also to ChangeLog.md? And if you're at it, you might also want to consider adding the good explanation you provided in #37 to the commit comment?

Thank You @gernot-h for the review. I have updated the changelog for this PR and also updated the commit message.

@its-sushant
Copy link
Contributor Author

By the way, do you know when this feature was added to SW360? I quickly checked in https://github.com/eclipse-sw360/sw360/blob/main/CHANGELOG.md, but couldn't find it at a first glance - might be helpful to also add this bit to the ChangeLog so users know if it's available or not.

Ok, found eclipse-sw360/sw360#2657, so I guess it's expected to be part of SW360 19.1, right?

Yes, I guess.

@deveaud-m deveaud-m requested a review from tngraf November 26, 2024 12:17
@gernot-h
Copy link
Collaborator

Thanks, @its-sushant, for addressing my comments! Change looks good to me now, I also triggered the unit tests, so @tngraf can merge if he agrees…

@tngraf tngraf merged commit 8406f4e into sw360:master Nov 26, 2024
5 checks passed
@tngraf
Copy link
Collaborator

tngraf commented Nov 26, 2024

Thanks, @its-sushant, @gernot-h, @deveaud-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to Add isNewClearingWithSourceAvailable Parameter to get_all_releases.
3 participants