Render SVG files at output resolution #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional dependency on librsvg to directly render the SVG images, instead of using gdk-pixbuf to draw them to an intermediate image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would close #60 .
rsvg_handle_new_from_filelets the SVG recursively load linked images (see https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/class.Handle.html#security-and-locations-of-referenced-files ; SVGs can already embed other image types via data-URI, and librsvg blocks web resources entirely.) Should this behavior be disabled?width="100%" height="100%"viewport -- gdk-pixbuf loaded them at 1x1 size.It is possible to render SVG files at higher resolution using just GdkPixbuf, but doing so is somewhat complicated, and appears to always preserve aspect ratio so that scaling/cropping afterwards is still necessary. See branch https://github.com/mstoeckl/swaybg/tree/pixbuf-scale for an example.
Edit: it looks like librsvg's headers produce a compilation error; this is probably something they should fix and that this should be considered blocked on? (filed as https://gitlab.gnome.org/GNOME/librsvg/-/issues/1136; edit: resolved, should appear in next release.)