Skip to content

feat(es/minifier): Remove unused parts of destructuring #11024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2025

Conversation

wjw99830
Copy link
Contributor

@wjw99830 wjw99830 commented Aug 22, 2025

Description:
If pure_getters is true, remove unused vars of destructuring while init is Expr::Ident.
We should follow user's configuration at least in simple scenarios.

BREAKING CHANGE:

Related issue (if exists): #10962

@wjw99830 wjw99830 requested a review from a team as a code owner August 22, 2025 20:57
Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 990edbc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Aug 22, 2025

CodSpeed Performance Report

Merging #11024 will not alter performance

Comparing wjw99830:fix/issue_10962 (990edbc) with main (bc83875)

Summary

✅ 140 untouched benchmarks

@wjw99830 wjw99830 changed the title Remove unused vars of destructuring while 'init' is identifier Remove unused vars of destructuring while init is Expr::Ident Aug 23, 2025
@kdy1 kdy1 requested a review from a team as a code owner August 23, 2025 11:27
@kdy1 kdy1 changed the title Remove unused vars of destructuring while init is Expr::Ident feat(es/minifier): Remove unused parts of destructuring Aug 23, 2025
@kdy1 kdy1 added this to the Planned milestone Aug 23, 2025
@kdy1 kdy1 merged commit b5fed8c into swc-project:main Aug 23, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants