Remove high dpi scaling option with Qt6 #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ltoenning
force-pushed
the
high_dpi_scaling
branch
2 times, most recently
from
932a006 to
0c77b87
Compare
This removes the --scale command line option. Qt6 seems to have this already integrated to scale according to the nativ display settings: https://doc.qt.io/qt-6.8/highdpi.html Adjusting the scale on a per-application basis is not intended (anymore) according to the documentation. Tested on a (near) high-dpi screen.
ltoenning
force-pushed
the
high_dpi_scaling
branch
from
0c77b87 to
ea0dc3b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes high DPI scaling functionality from the codebase, as Qt6 now handles high DPI scaling automatically according to native display settings. The PR eliminates the manual --scale command line option and related scaling components that are no longer needed.
Key changes:
- Removed scale screen factor component and related UI elements
- Eliminated high DPI scaling methods and command line options
- Updated Qt API usage to align with Qt6 standards (deprecated method replacements)
Reviewed Changes
Copilot reviewed 61 out of 61 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui/components/scalescreenfactor.* | Completely removed scale screen factor component files |
| src/swiftlauncher/swiftlauncher.* | Removed scale factor UI component and related functionality |
| src/gui/guiapplication.* | Removed high DPI scaling methods and command line options |
| src/misc/variant.* | Updated Qt API calls to use Qt6-compatible methods |
| samples/*/main.cpp | Removed high DPI scaling initialization calls |
| Multiple test files | Updated deprecated Qt datetime methods to use QTimeZone::utc() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the --scale command line option.
Qt6 seems to have this already integrated to scale according to the native display settings: https://doc.qt.io/qt-6.8/highdpi.html
Adjusting the scale on a per-application basis is not intended (anymore) according to the documentation. Tested on a (near) high-dpi screen.