-
-
Notifications
You must be signed in to change notification settings - Fork 384
[UX3] Start an UPGRADE file #3056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you for starting working on this, I added many comments to makes sure we stick to the Symfony's UPGRADE format, there is too much information not really useful
UPGRADE-3.0.md
Outdated
Symfony UX follows Symfony's release system. This means that major | ||
versions (like `3.0`) offer the same functionality as their previous minor | ||
versions (like `2.x`), once all deprecations have been removed. | ||
|
||
However, major versions may also introduce new features and improvements, and a | ||
bump in the required PHP or packages versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noneed to be superfluous:
Symfony UX follows Symfony's release system. This means that major | |
versions (like `3.0`) offer the same functionality as their previous minor | |
versions (like `2.x`), once all deprecations have been removed. | |
However, major versions may also introduce new features and improvements, and a | |
bump in the required PHP or packages versions. | |
Symfony UX follows Symfony's release process, 2.x and 3.0 have the same features, but Symfony UX 3.0 doesn't include any deprecated features. To upgrade, make sure to resolve all deprecation notices. Read more about this in the [Symfony documentation](https://symfony.com/doc/6.4/setup/upgrade_major.html#upgrade-major-symfony-deprecations). | |
However, major versions may also introduce new features and improvements, and a | |
bump in the required PHP or packages versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we target a release number here ? 31 would be nice I guess (30 may be short so let's keep it realistic ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree for the tone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a doc page to upgrade adapted to Symfony UX here ? I'm a bit afraid people do not understand what to do precisely here (we have no "extra" composer tag, etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0 is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a doc page to upgrade adapted to Symfony UX here ? I'm a bit afraid people do not understand what to do precisely here (we have no "extra" composer tag, etc..
The sections you added for removed packages are clear enough for me, and, what the extra
composer tag is about?
Thanks for the in-depth review. Updated accordingly |
81d4d8f
to
0490830
Compare
0490830
to
a6bb1df
Compare
Thank you @smnandre. |
We can either work with this MR or merge it in the 3.x branch (and then update the doc along the way)
I'd rather do the "merge" one but open to opinions here :)