Skip to content

Conversation

smnandre
Copy link
Member

Q A
Bug fix? no
New feature? no
Docs? yes
Issues Fix #...
License MIT

We can either work with this MR or merge it in the 3.x branch (and then update the doc along the way)

I'd rather do the "merge" one but open to opinions here :)

@carsonbot carsonbot added docs Improvements or additions to documentation Status: Needs Review Needs to be reviewed labels Aug 25, 2025
@carsonbot carsonbot changed the title [DOCS][UX3] Start an UPGRADE file [UX3] Start an UPGRADE file Aug 25, 2025
@smnandre smnandre requested a review from Kocal August 25, 2025 20:29
@smnandre smnandre added this to the 3.0 milestone Aug 25, 2025
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for starting working on this, I added many comments to makes sure we stick to the Symfony's UPGRADE format, there is too much information not really useful

UPGRADE-3.0.md Outdated
Comment on lines 3 to 8
Symfony UX follows Symfony's release system. This means that major
versions (like `3.0`) offer the same functionality as their previous minor
versions (like `2.x`), once all deprecations have been removed.

However, major versions may also introduce new features and improvements, and a
bump in the required PHP or packages versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noneed to be superfluous:

Suggested change
Symfony UX follows Symfony's release system. This means that major
versions (like `3.0`) offer the same functionality as their previous minor
versions (like `2.x`), once all deprecations have been removed.
However, major versions may also introduce new features and improvements, and a
bump in the required PHP or packages versions.
Symfony UX follows Symfony's release process, 2.x and 3.0 have the same features, but Symfony UX 3.0 doesn't include any deprecated features. To upgrade, make sure to resolve all deprecation notices. Read more about this in the [Symfony documentation](https://symfony.com/doc/6.4/setup/upgrade_major.html#upgrade-major-symfony-deprecations).
However, major versions may also introduce new features and improvements, and a
bump in the required PHP or packages versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we target a release number here ? 31 would be nice I guess (30 may be short so let's keep it realistic ?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree for the tone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a doc page to upgrade adapted to Symfony UX here ? I'm a bit afraid people do not understand what to do precisely here (we have no "extra" composer tag, etc..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0 is fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a doc page to upgrade adapted to Symfony UX here ? I'm a bit afraid people do not understand what to do precisely here (we have no "extra" composer tag, etc..

The sections you added for removed packages are clear enough for me, and, what the extra composer tag is about?

@smnandre
Copy link
Member Author

Thanks for the in-depth review. Updated accordingly

@smnandre smnandre requested a review from Kocal August 26, 2025 18:13
@Kocal Kocal force-pushed the docs/upgrade-ux-30 branch from 81d4d8f to 0490830 Compare September 1, 2025 19:13
@Kocal Kocal force-pushed the docs/upgrade-ux-30 branch from 0490830 to a6bb1df Compare September 1, 2025 19:14
@Kocal
Copy link
Member

Kocal commented Sep 1, 2025

Modified changelogs from TwigComponent and LiveComponent, according removed deprecations from #3040 and #3051, added migration steps in UPGRADE-3.0.md

@Kocal
Copy link
Member

Kocal commented Sep 1, 2025

Thank you @smnandre.

@Kocal Kocal merged commit bd3c7b9 into symfony:3.x Sep 1, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants