Added thelio-major-r5-n3 to current models. #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed thelio-major-r3 from current models. Already in previous models.
leviport
requested changes
Jan 6, 2025
|
@leviport it looks like the major-r3 is currently in current and previous sections so this PR looks good. |
|
|
|
Ah, I missed it in Previous. This is good then. However, you should also update src/README.md so that the ToC on the first page matches the index on the side bar. |
leviport
approved these changes
Jan 6, 2025
|
Good catch! |
|
Thank you for the fix, it looks like this was initially done properly when R5-N3 was added but had been rolled back in one of the Astra commits: 6077873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thelio-major-r3 tech docs are in both the current and previous models. I removed it from current and added the thelio-major-r5-n3 tech docs to the current models. Please double check that I did this right. 😄