chore(sdf, dal): Cleanup old pre-REBAC routes #5247
Conversation
github-actions
bot
added
A-sdf
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
| path: () => "/change_set/begin_abandon_approval_process", | ||
| force_apply: { | ||
| path: (vars: ROUTE_VARS) => | ||
| `/v2/workspaces/${vars.workspaceId}/change-sets/${vars.changeSetId}/force_apply`, | ||
| method: "POST", | ||
| }, | ||
| begin_approval_process: { |
There was a problem hiding this comment.
are we using this still? or can this one get cleaned up?
Way back when, I was considering keeping the low-fi approval flow for things like 'abandon change set' (as it gives people who are on the change set a chance to stop the abandon if they're actively doing something) but wasn't totally sure...
There was a problem hiding this comment.
I do see that an endpoint still is called so I left it in place - it's when the user is an approver or an owner and they force their own approval
There was a problem hiding this comment.
Sorry bad github comment location - I meant the begin_approval_process pieces
There was a problem hiding this comment.
Definitely not for this PR - just leaving a note that we need to update both this client and the tests to account for views when we clean up that feature flag
No description provided.