chore: reset network

[SWvheerden]

Description

reset network

Summary by CodeRabbit

• Bug Fixes
  • Updated genesis block creation with a new timestamp and computed values, replacing previous temporary workarounds.
• Refactor
  • Standardized block validations to ensure all blocks are thoroughly and uniformly checked.
• Chores
  • Adjusted network identification settings to enhance compatibility and communication across supported networks.

[coderabbitai]

Walkthrough

The pull request updates the genesis block generation, header validation, and network configuration. In genesis block functions, temporary zero hash assignments have been removed, the genesis timestamp has been updated, and test assertions now compute expected Merkle roots. The header validator no longer bypasses checks via a whitelist, enforcing full validation for all blocks. Additionally, the wire byte values for NextNet and Esmeralda networks have been adjusted.

Changes

File(s)	Summary of Changes
base_layer/core/.../genesis_block.rs	Removed hardcoded zero hashes in genesis block functions, updated genesis timestamp from "28 Jan 2025" to "11 Mar 2025", added specific block output Merkle root, and refactored test assertions.
base_layer/core/.../header_full_validator.rs	Removed WHITELISTED_HEADERS and associated bypass logic, enforcing full header validation without conditional exceptions.
common/src/.../network.rs	Updated wire byte values in the as_wire_byte method: NextNet from 80 to 81 and Esmeralda from 201 to 202.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant G as Genesis Block Module
    participant V as Header Validator
    participant T as Test Suite

    C->>G: Request genesis block (NextNet/Esmeralda)
    G->>G: Generate block header (set new timestamp & compute Merkle roots)
    G->>V: Submit header for full validation
    V-->>G: Return validation result
    G-->>C: Provide generated genesis block
    T->>G: Retrieve block details for testing
    G-->>T: Return computed Merkle roots
    T->>T: Assert expected vs. actual values

Loading

Poem

Hoppity hop, I scurry with cheer,
Tweaks in the genesis now make it clear.
No more zero hacks in our code so bright,
Headers are validated with pure might.
Wire bytes shift as the networks play—
A bunny’s joy in every byte today!
🐇🥕✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d9a686d and 6b6c925.

📒 Files selected for processing (3)

• base_layer/core/src/blocks/genesis_block.rs (4 hunks)
• base_layer/core/src/validation/header/header_full_validator.rs (2 hunks)
• common/src/configuration/network.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: test (mainnet, stagenet)
• GitHub Check: test (nextnet, nextnet)
• GitHub Check: Cucumber tests / FFI
• GitHub Check: ci
• GitHub Check: cargo check with stable
• GitHub Check: Cucumber tests / Base Layer

🔇 Additional comments (8)

common/src/configuration/network.rs (2)

108-108: Network wire byte updated for NextNet

The wire byte for NextNet has been incremented from 80 to 81. This change is appropriate for resetting the network as per the PR objective. The new value still falls within the defined NEXT_NET_RANGE (80..120) and follows the guideline to not reuse previous values.

---

114-114: Network wire byte updated for Esmeralda

The wire byte for Esmeralda has been incremented from 201 to 202. This change is appropriate for resetting the network as per the PR objective. The new value still falls within the defined ESMERALDA_RANGE (200..240) and follows the guideline to not reuse previous values.

base_layer/core/src/validation/header/header_full_validator.rs (2)

25-25: Import list simplified

Removed the debug import from log, keeping only the warn import which is being used. This cleanup is appropriate as part of the network reset.

---

72-81: Removed header validation whitelist

The code now applies all validation checks to all headers unconditionally, removing what appears to have been a whitelist-based bypass mechanism. This change enforces consistent validation rules across all blocks, which is a security improvement.

The validation functions now always check for:

• Bad blocks
• Blockchain version
• Height validity
• Previous hash correctness
• Timestamp validity
• PoW data validity

This standardized validation approach is more secure and maintainable.

base_layer/core/src/blocks/genesis_block.rs (4)

227-227: Updated NextNet genesis timestamp

The genesis timestamp for NextNet has been updated to "11 Mar 2025". This future date is appropriate for a network reset, giving adequate lead time for planning and announcement.

---

392-393: Added block_output_mr for Esmeralda genesis

Added a specific hash value for the Esmeralda genesis block's block_output_mr field, likely replacing a previous temporary zero hash. This improves the genesis block's integrity by providing a proper merkle root instead of a placeholder.

---

410-410: Updated Esmeralda genesis timestamp

The genesis timestamp for Esmeralda has been updated to "11 Mar 2025". This future date is appropriate for a network reset, giving adequate lead time for planning and announcement. It's also consistent with the NextNet timestamp update.

---

739-759: Improved test assertions for genesis blocks

The test assertions have been significantly improved by replacing checks for hardcoded zero hashes with proper calculations of expected Merkle roots based on the block's body. This change:

1. Verifies the block_output_mr with both the AggregateBody calculation and the pruned MMR hash
2. Properly validates the input_mr against the calculated hash from the pruned input MMR

These improvements ensure that genesis blocks are correctly constructed and validated, enhancing the overall integrity of the network reset process.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results (CI)

    3 files    129 suites   36m 1s ⏱️
1 352 tests 1 352 ✅ 0 💤 0 ❌
4 054 runs  4 054 ✅ 0 💤 0 ❌

Results for commit 6b6c925.