fix: startup arg

[SWvheerden]

Description

Fixes the startup arg of libtor data dir. This clashes with the log dir by default. This changes libtor to rather use -z

Summary by CodeRabbit

• New Features
  • Improved the command-line interface by introducing a dedicated shortcut for specifying the data directory. The option now requires using an explicit “-z” flag, enhancing clarity and consistency when launching the tool. Users will enjoy the same underlying functionality with a more intuitive flag for accessing the data directory.

[coderabbitai]

Walkthrough

The CLI configuration for the libtor_data_dir field in the Minotari Console Wallet has been updated. The change explicitly sets the short flag to 'z' using the #[clap] macro instead of relying on the default. The field remains functionally identical, continuing to accept an optional PathBuf. This update solely affects how the command-line argument is accessed.

Changes

File Path	Change Summary
applications/minotari_console_wallet/src/cli.rs	Updated #[clap(short, long, parse(from_os_str))] to #[clap(short = 'z', long, parse(from_os_str))] for libtor_data_dir.

Possibly related PRs

• fix: libtor cli option #6877: Adjusts the libtor_data_dir flag in the Cli struct by explicitly setting the short flag to 'z', directly relating to this change.

Poem

I'm a little rabbit with code in my stride,
Hopping through updates with a joyful pride.
The flag now sings with a bright 'z' cheer,
Guiding the CLI both far and near.
Carrots and commits, let the magic appear!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa7e286 and 74aa248.

📒 Files selected for processing (1)

• applications/minotari_console_wallet/src/cli.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: test (nextnet, nextnet)
• GitHub Check: test (mainnet, stagenet)
• GitHub Check: test (testnet, esmeralda)
• GitHub Check: ci
• GitHub Check: cargo check with stable
• GitHub Check: Cucumber tests / Base Layer
• GitHub Check: Cucumber tests / FFI

🔇 Additional comments (1)

applications/minotari_console_wallet/src/cli.rs (1)

103-103: LGTM: Good change to resolve command-line flag conflict.

This change explicitly sets the short flag for libtor_data_dir to -z instead of relying on the default (which was likely -l). This helps resolve the conflict between the libtor data directory and log directory flags mentioned in the PR objective. Users who previously used the default short flag will need to update their commands, but this is necessary to ensure proper functionality.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results (CI)

    3 files    129 suites   44m 25s ⏱️
1 352 tests 1 352 ✅ 0 💤 0 ❌
4 054 runs  4 054 ✅ 0 💤 0 ❌

Results for commit 74aa248.

[github-actions]

Test Results (Integration tests)

18 tests  +18   18 ✅ +18   5m 55s ⏱️ + 5m 55s
 2 suites + 2    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 
 1 errors

For more details on these parsing errors, see this check.

Results for commit 74aa248. ± Comparison against base commit aa7e286.

[Copilot]

Pull Request Overview

This PR fixes the startup argument for the libtor data directory by changing its CLI flag to use an explicit -z option, preventing conflicts with the log directory.

• Updated the short CLI flag for the libtor data directory to '-z'.
• Resolved a naming conflict between libtor data directory and log directory options.

Comments suppressed due to low confidence (1)

applications/minotari_console_wallet/src/cli.rs:103

• Verify that the new '-z' short flag does not conflict with any other CLI options to ensure consistent behavior across the application.

#[clap(short = 'z', long, parse(from_os_str))]