fix: excess sig order in the tx tab

[mmrrnn]

Description

In the minotari_console_wallet, the excess signature was displayed in the incorrect order, with the nonce appearing as the signature and the signature appearing as the nonce

• from applications/minotari_console_wallet/src/ui/state/app_state.rs (

  tari/applications/minotari_console_wallet/src/ui/state/app_state.rs

  Line 1195 in 61eda04

  let excess_signature = format!(

  )

        let excess_signature = format!(
            "{},{}",
            tx.transaction
                .first_kernel_excess_sig()
                .map(|s| s.get_signature().to_hex())
                .unwrap_or_default(),
            tx.transaction
                .first_kernel_excess_sig()
                .map(|s| s.get_compressed_public_nonce().to_hex())
                .unwrap_or_default()
        );

• from applications/minotari_console_wallet/src/ui/components/transactions_tab (https://github.com/tari-project/tari/blob/development/applications/minotari_console_wallet/src/ui/components/transactions_tab.rs#L338)

let excess_sig = Span::styled("Excess sig(nonce, sig):", Style::default().fg(Color::Magenta));

Summary by CodeRabbit

• Style
  • Updated a label in the transactions view to display parameters in a clearer, more logical order (“Excess sig(sig, nonce):”), enhancing the overall readability of transaction details.

[coderabbitai]

Walkthrough

The update modifies a UI element in the TransactionsTab by altering the label text in the draw_detailed_transaction method. The label now displays "Excess sig(sig, nonce):" instead of the previous "Excess sig(nonce, sig):". There are no changes to the underlying logic, control flow, or error handling.

Changes

File(s)	Change Summary
applications/.../transactions_tab.rs	Updated label in draw_detailed_transaction to swap parameter order from "Excess sig(nonce, sig):" to "Excess sig(sig, nonce):".

Suggested reviewers

• SWvheerden

Poem

In a burrow of code under moonlit skies,
I hop with joy as the label now flies.
A gentle tweak, a revised display,
Whiskers twitching at the new array.
Hoppy cheers from this rabbit’s day!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61eda04 and 88e0cad.

📒 Files selected for processing (1)

• applications/minotari_console_wallet/src/ui/components/transactions_tab.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: test (nextnet, nextnet)
• GitHub Check: test (mainnet, stagenet)
• GitHub Check: test (testnet, esmeralda)
• GitHub Check: cargo check with stable
• GitHub Check: ci

🔇 Additional comments (1)

applications/minotari_console_wallet/src/ui/components/transactions_tab.rs (1)

338-338: Label Text Update: Correct Excess Signature Field Ordering

The label is now updated to "Excess sig(sig, nonce):", which clearly indicates that the actual signature is shown first followed by the nonce. This addresses the reported issue where the nonce and signature were previously swapped. Please verify that this label is consistent with the backend formatting logic (e.g., as adjusted in app_state.rs) and any related documentation or tooltips.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results (CI)

    3 files    129 suites   45m 34s ⏱️
1 352 tests 1 351 ✅ 0 💤 1 ❌
4 054 runs  4 053 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 88e0cad.

[github-actions]

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   18m 42s ⏱️ + 18m 42s
36 tests +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 
37 runs  +37  36 ✅ +36  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 88e0cad. ± Comparison against base commit 61eda04.