Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pyright against codebase #251

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Run pyright against codebase #251

merged 1 commit into from
Nov 27, 2023

Conversation

ahal
Copy link
Collaborator

@ahal ahal commented May 24, 2023

No description provided.

@ahal ahal self-assigned this Nov 24, 2023
@ahal ahal marked this pull request as ready for review November 24, 2023 21:35
@ahal ahal requested review from a team and bhearsum November 24, 2023 21:36
@ahal
Copy link
Collaborator Author

ahal commented Nov 24, 2023

This just excludes every file that has pre-existing errors. I didn't have time or motivation to fix everything, and this way we can improve things incrementally (and will at least get type checking on new files).

Once all existing errors are fixed, we can think about enforcing annotations.. but not yet.

Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!!

Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@ahal ahal merged commit 7ad54bd into taskcluster:main Nov 27, 2023
7 checks passed
@ahal ahal deleted the pyright branch November 27, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants