Normalize Path Separator in util.hash.py #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch @strseb. Side note: a good followup would be to add test coverage, https://app.codecov.io/github/taskcluster/taskgraph/blob/main/src%2Ftaskgraph%2Futil%2Fhash.py shows |
ahal
approved these changes
Nov 27, 2023
On windows str(Purepath()) is used for matching the pattern which will match nothing, given `\\` is in the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! :)
I just did setup taskgraph locally on a windows machine, and wanted to run the full moz-vpn taskgraph. That it was trying to match
taskcluster/scripts/toolchain/compile_openssl.ps1vs the windows pathtaskcluster\scripts\toolchain\compile_openssl.ps1therefore failed :c