Fix incorrect TARGET_TRIPLE for Apple simulator targets #3340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in Python-Apple-support's Makefile patch where the computed TARGET_TRIPLE for Apple simulator SDKs (iOS, tvOS, watchOS, visionOS) included a duplicate `-simulator` suffix. The Makefile logic checked for "simulator" in the SDK name, but the OS_LOWER already includes `-simulator` for these cases, resulting in invalid triples like `arm64-apple-ios-simulator-simulator`. Replaced the conditional logic with a unified form: TARGET_TRIPLE-$(target) = $(ARCH-$(target))-apple-$(OS_LOWER-$(target)) This resolves the issue and simplifies the Makefile logic.
|
having this problem as well |
|
it works well, i built successfully without the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in Python-Apple-support's Makefile patch where the computed TARGET_TRIPLE for Apple simulator SDKs (iOS, tvOS, watchOS, visionOS) included a duplicate
-simulatorsuffix.The Makefile logic checked for "simulator" in the SDK name, but the OS_LOWER already includes
-simulatorfor these cases, resulting in invalid triples likearm64-apple-ios-simulator-simulator.Replaced the conditional logic with a unified form:$(ARCH-$ (target))-apple-$(OS_LOWER-$(target))
TARGET_TRIPLE-$(target) =
This resolves the issue and simplifies the Makefile logic.