fix(IPCConnection): add good bit field, resolves #2

IPCConnection.cpp

@@ -23,7 +23,8 @@ IPCConnection::IPCConnection(std::string socketPath):
     _isWorkerTerminated(false),
 
     _messageId(0),
-    _ackId(0)
+    _ackId(0),
+    _isGood(true)
 {
 
 }
@@ -54,6 +55,10 @@ void IPCConnection::disconnect() {
     _socket.close();
 }
 
+bool IPCConnection::isGood() const {
+    return _isGood;
+}
+
 std::unique_ptr<ULIPCHeader, IPCConnection::MallocFreeDeleter> IPCConnection::nextHeader() {
     return std::move(read<ULIPCHeader>(sizeof(ULIPCHeader)));
 }
@@ -87,6 +92,8 @@ void IPCConnection::workerLoop() {
         0
     };
 
+    _isGood = true;
+
     while (!_isWorkerTerminated) {
         if (poll(&pollFd, 1, -1) < 0) {
             throw SystemCallException(errno, "poll");
@@ -138,6 +145,10 @@ void IPCConnection::workerLoop() {
                 }
             }
 
+            if (_isGood && retval <= 0) {
+                break;
+            }
+
             readPos += retval;
 
             if (readPos >= contentLength) {
@@ -154,6 +165,7 @@ void IPCConnection::workerLoop() {
 
         if (pollFd.revents & POLLHUP) {
             LOG(LOG_LEVEL_WARNING, "POLLHUP bit set");
+            _isGood = false;
 
             if (_readTasks.empty()) {
                 LOG(LOG_LEVEL_WARNING, "POLLHUP bit set; closing connection");
@@ -166,4 +178,6 @@ void IPCConnection::workerLoop() {
             break;
         }
     }
+
+    _isGood = false;
 }

IPCConnection.hpp

@@ -31,6 +31,8 @@ class IPCConnection {
      */
     void connect();
     void disconnect();
+
+    bool isGood() const;
 
     std::unique_ptr<ULIPCHeader, MallocFreeDeleter> nextHeader();
 
@@ -79,6 +81,8 @@ class IPCConnection {
     UnixSocket _socket;
     std::thread _workerThread;
     bool _isWorkerTerminated;
+
+    bool _isGood;
 
     std::mutex _writeTasksLock;
     std::mutex _readTasksLock;

ProjectionTarget.hpp

@@ -19,6 +19,8 @@ class ProjectionTarget {
         size_t size,
         int32_t width, int32_t height
     ) = 0;
+
+    virtual void ipcDisconnected() = 0;
 };
 
 #endif //ULALACA_PROJECTIONCONTEXT_HPP

ProjectorClient.cpp

@@ -52,7 +52,13 @@ void ProjectorClient::handleEvent(XrdpEvent &event) {
     if (_isTerminated) {
         return;
     }
-
+
+    if (!_ipcConnection.isGood()) {
+        _target.ipcDisconnected();
+        this->stop();
+        return;
+    }
+
     if (event.isKeyEvent()) {
         auto keycode = event.param3;
         auto cgKeycode = rdpKeycodeToCGKeycode(keycode);
@@ -176,7 +182,7 @@ void ProjectorClient::setOutputSuppression(bool isOutputSuppressed) {
 }
 
 void ProjectorClient::mainLoop() {
-    while (!_isTerminated) {
+    while (!_isTerminated && _ipcConnection.isGood()) {
         auto header = _ipcConnection.nextHeader();
 
         switch (header->messageType) {

ProjectorClient.hpp

@@ -38,7 +38,7 @@ class ProjectorClient {
 
 private:
     void mainLoop();
-    
+
     ProjectionTarget &_target;
     IPCConnection _ipcConnection;
 

XrdpUlalacaPrivate.cpp

@@ -144,6 +144,11 @@ void XrdpUlalacaPrivate::commitUpdate(const uint8_t *image, size_t size, int32_t
     });
 }
 
+void XrdpUlalacaPrivate::ipcDisconnected() {
+    LOG(LOG_LEVEL_WARNING, "ipc disconnected");
+    _error = 1;
+}
+
 void XrdpUlalacaPrivate::updateThreadLoop() {
     while (_isUpdateThreadRunning) {
         while (_updateQueue.empty()) {

XrdpUlalacaPrivate.hpp

@@ -79,13 +79,15 @@ class XrdpUlalacaPrivate: public ProjectionTarget {
     inline int decideCopyRectSize() const;
     inline std::unique_ptr<std::vector<ULIPCRect>> createCopyRects(std::vector<ULIPCRect> &dirtyRects, int rectSize) const;
 
-    void addDirtyRect(ULIPCRect &rect);
-    void commitUpdate(const uint8_t *image, size_t size, int32_t width, int32_t height);
+    void addDirtyRect(ULIPCRect &rect) override;
+    void commitUpdate(const uint8_t *image, size_t size, int32_t width, int32_t height) override;
+    void ipcDisconnected() override;
 
     void updateThreadLoop();
 
     void calculateSessionSize();
 
+    inline bool isNSCodec() const;
     inline bool isRFXCodec() const;
     inline bool isJPEGCodec() const;
     inline bool isH264Codec() const;

XrdpUlalacaPrivate.xrdpmodule.cpp

@@ -118,6 +118,10 @@ int XrdpUlalacaPrivate::libModGetWaitObjs(tbus *readObjs, int *rcount, tbus *wri
         return 0;
     }
 
+    if (_error != 0) {
+        return 1;
+    }
+
     readObjs[(*rcount)++] = _projectorClient->descriptor();
     writeObjs[(*wcount)++] = _projectorClient->descriptor();