Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fabric 1.21.4 support #82

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Add Fabric 1.21.4 support #82

merged 2 commits into from
Mar 19, 2025

Conversation

ZekeZDev
Copy link
Contributor

@ZekeZDev ZekeZDev commented Mar 16, 2025

fixes inventory issue in 1.21.4 by making the simple changes to update to 1.21.4. This was a very quick patch so if this does not conform to standards etc please let me know.

fixes: #81

@ZekeZDev ZekeZDev changed the title Add 1.21.4 support Add Fabric 1.21.4 support Mar 16, 2025
@ZekeZDev
Copy link
Contributor Author

[12:22:35] [OkHttp https://plugin.tebex.io/.../ERROR]: Unexpected status code when sending server events
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: java.io.IOException: Unexpected status code (400)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at knot//io.tebex.sdk.SDK.lambda$_batchServerEvents$17(SDK.java:610)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at java.base/java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2179)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at knot//io.tebex.sdk.request.TebexRequest$1.onResponse(TebexRequest.java:145)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at knot//io.tebex.plugin.libs.okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
[12:22:35] [OkHttp https://plugin.tebex.io/.../INFO]: [STDERR]: at java.base/java.lang.Thread.run(Thread.java:1583)

the link sent in chat doesnt seem to take to the correct product page I am unsure why this is and if this is an issue specific to this patch or is a wider issue.

@WildBamaBoy
Copy link
Collaborator

While this at first appears to be a branch from 2.2.0, it looks like the code comes from 2.1.1 thus some Fabric-specific fixes in the recent version would not be included?: https://github.com/tebexio/Tebex-Minecraft/pull/82/files#diff-cd6758e309a939ce89a77182ef9e77c8dd8ca1d7a3bda5fc00ac4c68f9d39b1dR45

@WildBamaBoy WildBamaBoy added the question Further information is requested label Mar 17, 2025
@ZekeZDev
Copy link
Contributor Author

While this at first appears to be a branch from 2.2.0, it looks like the code comes from 2.1.1 thus some Fabric-specific fixes in the recent version would not be included?: https://github.com/tebexio/Tebex-Minecraft/pull/82/files#diff-cd6758e309a939ce89a77182ef9e77c8dd8ca1d7a3bda5fc00ac4c68f9d39b1dR45

afaik I built from 2.2.0 branch, the 1.21.1 fabric code I based on did have 2.1.1 in the gradle properties but that is the same here upstream.

@WildBamaBoy WildBamaBoy removed the question Further information is requested label Mar 19, 2025
@WildBamaBoy
Copy link
Collaborator

You are correct, thanks for the clarification

@WildBamaBoy WildBamaBoy merged commit 579d6c8 into tebexio:2.2.0 Mar 19, 2025
Euphillya added a commit to Euphillya/Tebex-Folia that referenced this pull request Mar 30, 2025
tebexio@a072803 feat(velocity): add better suggestions
tebexio@eacfe11 fix: utilize permission nodes on fabric
tebexio@4a7455f apply version explicitly
tebexio@5bf8e4c Fix threads not properly shutting down on fabric
tebexio@7bafde6 Merge pull request tebexio#74 from Shmeeb/shutdown-fix
tebexio@30a9bed centralize multithreading code, add tick scheduler for fabric
tebexio@53f732d fix: online commands did not respect command delays
tebexio@0b832c6 cleanup analyse naming
tebexio@ef599d2 fix: server events use Instant for UTC timing
tebexio@7d92ee7 add new server event call
tebexio@86dbd06 fix: don't allow pickup of /buy items, don't allow placement of inventory items
tebexio@adfdea2 use multithreading for blocking now calls
tebexio@bc9c990 Update Multithreading.java
tebexio@3a6cf01 fix: improper / noop row calculations on bukkit
tebexio@89fbde8 feat: anonymize join event IPs
tebexio@4067465 chore: bump version
tebexio@bf3242b backport 86dbd06
tebexio@7e18db4 add 1.21.4 support
tebexio@b67a137 fix build.sh
tebexio@20d10b9 fix: format date in UTC in a format always compliant with Tebex API
tebexio@2ab5858 ix: remove runtime exception from coupons request tebexio#78
tebexio@579d6c8 Merge pull request tebexio#82 from QUT-MC-Club/2.2.0
tebexio@d5d7a68 Merge branch '2.2.0' into 2.2.1
tebexio@831f486 Merge pull request tebexio#70 from RealBauHD/feat/better-suggestions
tebexio@76dd2dc Merge pull request tebexio#83 from tebexio/2.1.0
tebexio@878bcef Merge branch '2.2.0' into 2.2.1
tebexio@955a195 fix: proper version replacement to stop version snafus
tebexio@9bca00a fix: stop unnecessary requests without valid key
tebexio@049dd9f feat: send server inits to events
tebexio@72e094c change: refreshListings should only refresh listings
tebexio@3e2c007 ensure store info is set on load from config

And fix min delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes Fabric server 1.21.4
2 participants