Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Refactor to use latest modules provided by terraform-aws-modules #366

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Nearly all resources have been removed/replaced with the latest terraform-aws-modules equivalents
    • The VPC module has been removed entirely since most users will already have an existing VPC implementation
    • SSM parameters are no longer created within the module - handling secrets has been moved out of the module and left to users discretion
  • Git provider specific implementation details have been removed from the root module. Users are able to pass the necessary Atlantis environment variables (or flags via container definition cmd) for the git provider of their choosing, as well as any other Atlantis settings they wish to utilize. Only the bare minimum Atlantis settings are provided in the module (Atlantis URL and port)
  • Examples have been updated/replaced with two examples that demonstrate usage with GitHub in both a "complete" setup where the module creates nearly all resources required (save for the necessary integration bits, etc.), as well as a separated setup that demonstrates how users can utilize an existing ECS cluster and/or application load balancer (ALB)
  • Doc examples have been updated and consolidated:
    • A supplemental doc section has been added that will be used to help demonstrate how users can integrate with other git providers such as GitLab and BitBucket, plus demonstrate common alternate configurations such as using a GitHub app for authenticated access
    • The ALB authenticated listener examples have been re-located to the ALB modules usage patterns docs. Since this module is really a wrapper around a collection of other modules the focus of the docs are really scoped to Atlantis specifics and any module level (think infrastructure level) changes are relegated to their respective module repository
  • The GitHub and GitLab provider blocks have been removed from their respective webhook sub-modules. Its better to let users specify this so that they have full access to how they wish to configure the providers

Motivation and Context

Breaking Changes

  • Yes - due to the nature of Atlantis and the fact that it does not store any state, the recommended migration path is for users to de-provision their current implementation, and then re-provision using the updated syntax/configuration

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@@ -7,6 +9,7 @@
# .tfstate files
*.tfstate
*.tfstate.*
*.tfplan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move these two additions to your global gitignore file?

@bryantbiggs bryantbiggs merged commit 65d1982 into terraform-aws-modules:master Nov 4, 2023
9 checks passed
@bryantbiggs bryantbiggs deleted the refactor/ecr-module branch November 4, 2023 13:19
antonbabenko pushed a commit that referenced this pull request Nov 4, 2023
## [4.0.0](v3.28.0...v4.0.0) (2023-11-04)

### ⚠ BREAKING CHANGES

* Refactor to use latest modules provided by `terraform-aws-modules` (#366)

### Features

* Refactor to use latest modules provided by `terraform-aws-modules` ([#366](#366)) ([65d1982](65d1982))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

Copy link

github-actions bot commented Dec 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants