fix: Correct EFS mount and correct listener authentication when value is not provided #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not provided Signed-off-by: Bryant Biggs <bryantbiggs@gmail.com>
antonbabenko
approved these changes
Nov 10, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Nov 10, 2023
### [4.0.1](v4.0.0...v4.0.1) (2023-11-10) ### Bug Fixes * Correct EFS mount and correct listener authentication when value is not provided ([#368](#368)) ([e031208](e031208))
|
This PR is included in version 4.0.1 🎉 |
|
Nice, I came here to report the cognito/oidc bug in |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
authenticate_cognitoandauthenticate_oidcwith an overriding argument ofhttps_listenerwhere those values can be provided by usersMotivation and Context
authenticate_cognitoorauthenticate_oidcof the HTTPs listener, Terraform throws an error that a default action was not provided. This is because the argument keys are provide, but not values, and the underlying ALB module is only checking to see if the key is present to determine if it should create the associated configuration. This must have been a late change on v9.0 that wasn't caught, because the module currently does not work as intendedBreaking Changes
authenticate_cognitoandauthenticate_oidcbut since I cannot deploy the module as its written today and this is on the back of a major release I believe a patch release is sufficientHow Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request