Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACM module outputs to top-level atlantis module outputs #373

Conversation

danielpops
Copy link

Description

Add the ACM module outputs to the top-level atlantis module outputs

Motivation and Context

To add additional https listeners, I want to reference the ACM certificate ARN

Breaking Changes

None

How Has This Been Tested?

Modified locally and used as

module "atlantis"  {
  [...]

  alb = {
    listeners = {
      https_unauth = {
        port            = 8443
        protocol        = "HTTPS"
        ssl_policy      = "ELBSecurityPolicy-TLS13-1-2-Res-2021-06"
        certificate_arn = module.atlantis.acm.acm_certificate_arn
        forward = {
          target_group_key = "atlantis"
        }
      }
    }
   [...]
  }
  [...]
}

@bryantbiggs
Copy link
Member

hmm, I think we'll need to think about this because this looks cyclical and I'm skeptical that it would work if applied from scratch. I'll have to see if we can have a self-referencing value since the cert is created internally

@danielpops
Copy link
Author

hmm, I think we'll need to think about this because this looks cyclical and I'm skeptical that it would work if applied from scratch. I'll have to see if we can have a self-referencing value since the cert is created internally

Fair enough, I think I did not test it out from scratch, only after adding the additional listener. I'm also open to any other suggestions on how to achieve the goal of using the generated SSL certificate for additional listeners.

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 21, 2023
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Dec 31, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants