Fix issue 249 #286
Merged
Fix issue 249 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1024
💛 - Coveralls |
eerkunt
requested changes
Jun 5, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # CHANGELOG | |||
|
|
|||
| ## 1.2.5 (2020-05-25) | |||
There was a problem hiding this comment.
2020-06 :)
Btw, better not to change any CHANGELOG on a PR, since multiple PRs can happen simultaneously.
eerkunt
requested changes
Jun 7, 2020
| @@ -40,6 +40,7 @@ def it_must_contain_something(_step_obj, something, inherited_values=Null): | |||
|
|
|||
| if isinstance(found_key, dict): | |||
| found_value = jsonify(found_key.get(something, found_key)) | |||
| found_value = found_value if found_value != [] and found_value != '' else found_key | |||
There was a problem hiding this comment.
Lets change this conditions to ;
found value = found_value if found_value not in ([], '') else found_key| @@ -137,6 +138,7 @@ def it_must_not_contain_something(_step_obj, something, inherited_values=Null): | |||
|
|
|||
| if isinstance(found_key, dict): | |||
| found_value = jsonify(found_key.get(something, found_key)) | |||
| found_value = found_value if found_value != [] and found_value != '' else found_key | |||
Comment on lines
9
to
13
| Scenario: Ensure that waf_policy for ALB/CF tag is defined | ||
| Given I have aws_alb defined | ||
| When it has tags | ||
| Then it must contain waf_policy | ||
| And its value must match the "^(internal|external|custom)$" regex |
There was a problem hiding this comment.
When it has tagswill not drill down to the resource. waf_policy exists in tags parameter, thus the test must be changed like ;
Scenario: Ensure that waf_policy for ALB/CF tag is defined
Given I have aws_alb defined
When it has tags
Then it must contain tags
And it must contain waf_policy
And its value must match the "^(internal|external|custom)$" regex
Comment on lines
15
to
18
| Scenario: Ensure that waf_custom for ALB/CF tag is defined | ||
| Given I have aws_alb defined | ||
| When it has tags | ||
| Then it must contain waf_custom |
eerkunt
approved these changes
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On then/it_must_contain_something.py, if the value on "{something: value}" was an empty string/list, the step would evaluate the "something" key to be not existing inside the values.