Improve README formatting and enhance adblocker functionality #3016
Conversation
…e annotations, and enhance adblocker plugin functionality
* **inject-cliqz-preload.ts** - Remove try-catch block around import statement * **blocker.ts** - Remove try-catch block around ElectronBlocker.fromLists call * **tsconfig.json** - Remove all comments from the JSON file * **adSpeedup.ts** - Remove void return type from speedUpAndMute function
I see nothing of the sort, is this meant to be a draft PR? |
Probably at the beginning when I was trying to improve some of the procedure on the adblock working way, but apparently wasn't good, so I remove it following the comments I'll probably have a look later to see if I can do something else |
|
adding a try/catch and simply logging the error does not "enhance" the adblocker's "functionality" in any way, |
|
for UI stuff we usually use solid-js |
|
Are you asking AI IDEs like Cursor to "improve my code"? |
|
Holy smokes, 8,503 additions? Dude, no matter the quality of your PR, changes this big are impossible to review and merge. If you actually care about contributing, then I recommend splitting up your PR in digestible chunks. You'll do both yourself and the reviewer a favor :^) PS: That way even if the reviewer rejects certain parts of your changes, they won't reject all of your changes. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the overall formatting of the README and changelog files across multiple languages and updates the ESLint configuration, TypeScript annotations, and adblocker plugin functionality.
- Updated markdown formatting (e.g., consistent use of single quotes for image captions and standardized section headings) in various README files (ru, ko, is, hu, fr, es, and main README).
- Improved ESLint configuration formatting for better readability and maintained consistency in GitHub workflows and issue templates.
- Minor code refactoring changes, such as condition formatting in docs/js/main.js, and enhanced type annotations in the adblocker plugin.
Reviewed Changes
Copilot reviewed 60 out of 64 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | Reformatted configuration objects with standardized commas |
| docs/readme/README-ru.md | Updated image quoting and content list to improve readability |
| docs/readme/README-ko.md | Adjusted screenshot quotes and list ordering for consistency |
| docs/readme/README-is.md | Modified image quoting and reordered sections in the table of contents |
| docs/readme/README-hu.md | Refined markdown table and content ordering for clarity |
| docs/readme/README-fr.md | Standardized quotes and content ordering in the demonstration image |
| docs/readme/README-es.md | Adjusted image quotes and reordered sections for consistency |
| docs/js/main.js | Reformatted condition expressions with vertical alignment |
| changelog.md | Updated changelog entry formatting for consistent styling |
| README.md | Modified image quotes, headings, and text blocks for improved clarity |
| .github/**/.yml and ISSUE_TEMPLATE/.yml | Updated string quoting consistency across GitHub workflow and template files |
Files not reviewed (4)
- docs/index.html: Language not supported
- docs/style/fonts.css: Language not supported
- docs/style/style.css: Language not supported
- license: Language not supported
Update README and changelog formatting, improve TypeScript type annotations, and enhance the functionality of the adblocker plugin.