feat: support custom fs #136
Conversation
| @@ -25,13 +26,23 @@ export type PathsOutput = string[]; | |||
|
|
|||
| export type Output = OnlyCountsOutput | PathsOutput | GroupOutput; | |||
|
|
|||
| export type FSLike = { | |||
There was a problem hiding this comment.
this is purposely explicit rather than just FSLike = typeof nativeFs since the fs module has all sorts of exports (both types and actual exports) which we don't want to have to stub out to satisfy the type when bringing our own fs-like object
Adds a new `fs` option for specifying your own `fs` implementation.
|
was about to start working on this, then saw you had already implemented and pr'd it!! thanks a lot. hopefully @thecodrr can review soon 🙏 |
|
This is awesome! |
|
it truly is |
| import type { Dirent } from "fs"; | ||
| import * as nativeFs from "fs"; |
There was a problem hiding this comment.
just a style question probably for @thecodrr, but I wonder if these two lines should be combined into a single line
|
I noticed there aren't any docs being updated as part of this PR. That would probably be nice to add |
| }) | ||
| .crawl("node_modules"); | ||
| await api[type](); | ||
| if (type === 'withPromise') { |
There was a problem hiding this comment.
this might need to be double quotes to align with the project's style. i'm in the habit of using single quotes too though 😄
There was a problem hiding this comment.
Surprised it doesn't have a formatter setup, unless I just missed it somehow
If that doesn't exist, I'll open a separate pr to add prettier
Adds a new
fsoption for specifying your ownfsimplementation.Fixes #134