Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to MODULE.bazel to support Bazel 7 #6

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

mikael-s-persson
Copy link
Collaborator

Migrate to MODULE.bazel to support Bazel 7

Bazel 7 just came out and it is backward incompatible with existing WORKSPACE dependencies. This particular repo is not immediately affected, but up-stream repos are, such as x-edr-eigenmath, and mobility repos. The root problem is that there is a race between MODULE.bazel migration in Bazel and migrations away from native rules in rules_cc and rules_proto, which means that in the current state, things are very broken when using protobuf unless we migrate immediately to MODULE.bazel.

@mikael-s-persson mikael-s-persson requested a review from a team as a code owner December 18, 2023 20:22
@mikael-s-persson mikael-s-persson self-assigned this Dec 18, 2023
@mikael-s-persson mikael-s-persson merged commit 58dd778 into main Dec 19, 2023
3 checks passed
@mikael-s-persson mikael-s-persson deleted the feature/bzlmod_migration branch December 19, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants