Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docsy] Configure Google Custom Search Engine but leave it disabled #92

Merged
merged 4 commits into from
Oct 5, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Oct 4, 2024

NOTE: as mentioned in subsequent comments, I can't get GCSE to work fully under the current CSP, so I've decided to leave in the partial code changes, but disable search entirely for now, until we find & agree upon a viable search solution.

@chalin chalin added the docsy Docsy branch, and Docsy related items label Oct 4, 2024
@chalin chalin mentioned this pull request Oct 4, 2024
7 tasks
@chalin chalin force-pushed the chalin-im-gcse-2024-10-04 branch from bbd21c5 to 87a5262 Compare October 4, 2024 10:09
@chalin
Copy link
Collaborator Author

chalin commented Oct 4, 2024

Got this implementation working at 80%, but Google is using JS eval for each search entry, it seems :-/

image

I'm not finding a clean way to support GCSE, so I'm going to put this in draft mode for now, until @JustinCappos chimes in. If we don't even want to use GCSE for this website, then I'll close this PR, and disable search until someone has time to enable offline search.

@chalin chalin marked this pull request as draft October 4, 2024 10:42
@chalin chalin force-pushed the chalin-im-gcse-2024-10-04 branch from 87a5262 to 4d3fda6 Compare October 5, 2024 14:12
@chalin chalin changed the title [docsy] Configure Google Custom Search Engine [docsy] Configure Google Custom Search Engine but leave it disabled Oct 5, 2024
@chalin chalin marked this pull request as ready for review October 5, 2024 14:14
@chalin chalin force-pushed the chalin-im-gcse-2024-10-04 branch from d53961d to e295b32 Compare October 5, 2024 14:25
@chalin chalin merged commit be0c41a into theupdateframework:docsy Oct 5, 2024
7 checks passed
@chalin chalin deleted the chalin-im-gcse-2024-10-04 branch October 5, 2024 14:26
@chalin chalin mentioned this pull request Oct 5, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsy Docsy branch, and Docsy related items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant