Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer: Accept username without @ in config file #416

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jku
Copy link
Member

@jku jku commented Aug 27, 2024

It seems harmless but useful to prefix usernames with @ if the username in configuration does not have the prefix already

It seems harmless but useful to prefix usernames with @ if
the one in configuration does not have the prefix already
@jku jku requested a review from joshuagl August 27, 2024 10:45
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this so quickly.

Change and test looks good!

@jku jku merged commit 317efea into theupdateframework:main Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants