Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for >4GB ISO by optionally supporting a second partition. Plus other small improvements. #131

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

cshandley-uk
Copy link

@cshandley-uk cshandley-uk commented Feb 19, 2025

Like many people, I've been desperately looking for something to replace Ventoy (due to it's huge number of mystery binary blobs, opaque build process & foreign origin), and GLIM came really close - it just didn't support ISOs >4GB. I've been able to solve that major limitation by adding support for a second partition that uses (say) Ext4. I've tried to keep to the style of your source code, made my changes as small as possible, and split the changes into small commits so you easily see what I've done & why.

I have also made some other small improvements which I hope you won't object to:

  • Detect if GPT (rather than MBR) is used, and warn that GRUB requires an extra BIOS Boot Partition for the non-EFI case.
  • Made BIOS installation optional if you pick EFI, in case you don't have a BIOS Boot Partition.
  • When using a single partition, the ISO folder has been moved from boot/iso/ to just iso/, so it's in the same location whether you use one or two partitions (simplifies documentation & code), as well as IMHO being easier for newbies to find.
  • Made "Ready to install GLIM" default to "No", so you can't accidentally proceed if you are just pressing enter without reading the prompts.
  • Made the Y/N prompts case insensitive.
  • Warn rather than error if there are more than 2 partitions on the block device. (My use case is having bootable ISOs on my external backup HD, so I can boot & restore all from one device - Ventoy allows that sort of thing. Plus the BIOS Boot Partition.)
  • Halt if there are multiple GLIM partitions, since it seems asking for trouble if just randomly pick one!
  • Added quoting so it can handle the spaces in $USBMNT, just in case of weird systems.

I've tested all these changes as much as I can, on a real physical machine (no VM).

…g default from Y to N, and putting a blank line before it. Allow all Y/N answers to be case insensitive.
…alling EFI without BIOS in case they don't have a BIOS Boot Partition.
…ther than silently failing). Ensure sensible behaviour if fdisk has unexpected output.
…extra BIOS Boot partition if installing for BIOS.
…not even clear if the pull request will be accepted. Also add two commented-out lines to add LVM & BTRFS support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant