-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for >4GB ISO by optionally supporting a second partition. Plus other small improvements. #131
Open
cshandley-uk
wants to merge
18
commits into
thias:master
Choose a base branch
from
cshandley-uk:DualPartitionSupport
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… there are more partitions.
…g default from Y to N, and putting a blank line before it. Allow all Y/N answers to be case insensitive.
…alling EFI without BIOS in case they don't have a BIOS Boot Partition.
…ther than silently failing). Ensure sensible behaviour if fdisk has unexpected output.
…extra BIOS Boot partition if installing for BIOS.
…not even clear if the pull request will be accepted. Also add two commented-out lines to add LVM & BTRFS support.
… detected. (Thanks to eugenesan.)
… GLIM partitions. (Thanks to eugenesan.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like many people, I've been desperately looking for something to replace Ventoy (due to it's huge number of mystery binary blobs, opaque build process & foreign origin), and GLIM came really close - it just didn't support ISOs >4GB. I've been able to solve that major limitation by adding support for a second partition that uses (say) Ext4. I've tried to keep to the style of your source code, made my changes as small as possible, and split the changes into small commits so you easily see what I've done & why.
I have also made some other small improvements which I hope you won't object to:
I've tested all these changes as much as I can, on a real physical machine (no VM).