Skip to content

feat: fix club announcements for 15+ announcements #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

reverileo
Copy link

Proposed changes

  • Handle the case for 15+ announcements

Brief description of rationale

Previously, the counter wouldn't go down as the user read the announcements. Now, it automatically fetches the next announcement as the user reads announcements off.

@reverileo reverileo requested a review from a team as a code owner October 30, 2024 19:49
@coveralls
Copy link

Coverage Status

coverage: 79.122% (+0.02%) from 79.098%
when pulling 41c7615 on reverileo:club-announcements-15
into f80a619 on tjcsl:dev.

@reverileo
Copy link
Author

Closing this in favor of a new approach. See PR #1760.

@reverileo reverileo closed this Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants