Skip to content

Add tests to logs + small bug fix #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

Add tests to logs + small bug fix #1753

merged 1 commit into from
Apr 20, 2025

Conversation

aarushtools
Copy link
Member

Proposed changes

  • Add tests to logs
  • Prevent bypass of logging by changing user_agent to one found in nonloggable_user_agents while logged in

Brief description of rationale

  • Tests increase coverage

@aarushtools aarushtools force-pushed the logs-pr branch 2 times, most recently from 73e5a62 to 03c8710 Compare March 31, 2025 20:57
@alanzhu0
Copy link
Member

alanzhu0 commented Apr 6, 2025

Thanks Aarush - also interesting idea for checking if a user is signed in for the nonloggable user agents, although maybe it's better just to get rid of the nonloggable user agents entirely...

@aarushtools aarushtools marked this pull request as ready for review April 14, 2025 16:32
@aarushtools aarushtools requested a review from a team as a code owner April 14, 2025 16:32
@alanzhu0 alanzhu0 merged commit 8d5c68c into tjcsl:dev Apr 20, 2025
3 of 5 checks passed
@aarushtools aarushtools deleted the logs-pr branch April 20, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants