Skip to content

feat: add csl status to header #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

Conversation

aarushtools
Copy link
Member

@aarushtools aarushtools commented Mar 31, 2025

Proposed changes

  • remove the old method of scraping the TJCSL status page
  • switch to a cached message in the header

Brief description of rationale

  • the old method doesn't work
  • keeps users better updated on tjcsl status without a manual dashboard announcement

@aarushtools aarushtools force-pushed the betteruptime-status branch 2 times, most recently from f36e656 to 3fbf7d8 Compare March 31, 2025 20:48
@aarushtools aarushtools marked this pull request as ready for review March 31, 2025 20:54
@aarushtools aarushtools requested a review from a team as a code owner March 31, 2025 20:54
@aarushtools aarushtools force-pushed the betteruptime-status branch 2 times, most recently from 3a52e79 to 948951a Compare March 31, 2025 22:18
@aarushtools aarushtools marked this pull request as draft April 2, 2025 03:49
@aarushtools aarushtools force-pushed the betteruptime-status branch 2 times, most recently from d5e4caa to 58ff082 Compare April 15, 2025 02:38
@aarushtools
Copy link
Member Author

What it looks like
Screenshot 2025-04-14 222600
Screenshot 2025-04-14 215146

Responsiveness test
https://github.com/user-attachments/assets/aac01ba4-d0b9-4c8f-b22f-ebe0ec9b5bd6

@aarushtools aarushtools force-pushed the betteruptime-status branch from 58ff082 to 2541b23 Compare April 15, 2025 02:43
@aarushtools aarushtools changed the title feat: add betterstatus embed feat: add csl status to header Apr 15, 2025
@aarushtools aarushtools force-pushed the betteruptime-status branch from 2541b23 to c480c2c Compare April 15, 2025 02:59
@aarushtools aarushtools marked this pull request as ready for review April 15, 2025 03:09
@aarushtools aarushtools force-pushed the betteruptime-status branch 2 times, most recently from 37894b0 to a107c47 Compare April 17, 2025 15:42
@alanzhu0
Copy link
Member

This looks nice! Are you also going to add the automatic pulling of status updates from the status page, or is that going to be a separate PR (or just dropping it entirely)?

@aarushtools
Copy link
Member Author

This looks nice! Are you also going to add the automatic pulling of status updates from the status page, or is that going to be a separate PR (or just dropping it entirely)?

I was thinking the way we make manual announcements for outages is best (because you can decide what to say rather than auto generated updates) and the user can click the new status icon when it's down to see the auto status updates if they wanted. If it's needed though I could do it in a future PR

@aarushtools aarushtools force-pushed the betteruptime-status branch from a107c47 to 18a554a Compare April 20, 2025 16:21
and rework method of scraping the TJCSL status page
@aarushtools aarushtools force-pushed the betteruptime-status branch from 18a554a to a0b8dad Compare April 20, 2025 16:21
@alanzhu0
Copy link
Member

ok, sounds good - this is great!

@alanzhu0 alanzhu0 merged commit 79e9018 into tjcsl:dev Apr 20, 2025
4 checks passed
@aarushtools aarushtools deleted the betteruptime-status branch April 20, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants