Skip to content

fix(announcements): missing migration #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Conversation

aarushtools
Copy link
Member

@aarushtools aarushtools commented Apr 15, 2025

#1733 may have been missing a migration, which causes tests to fail for other prs

@aarushtools aarushtools marked this pull request as ready for review April 15, 2025 17:07
@aarushtools aarushtools requested a review from a team as a code owner April 15, 2025 17:07
Copy link
Member

@alanzhu0 alanzhu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this (smh @JasonGrace2282 )

@alanzhu0 alanzhu0 merged commit 1c976da into tjcsl:dev Apr 18, 2025
4 of 5 checks passed
@JasonGrace2282
Copy link
Member

JasonGrace2282 commented Apr 18, 2025

thanks for catching this (smh @JasonGrace2282 )

In my defense, it makes no sense that changing a help text requires a new migration!

@aarushtools aarushtools deleted the migrations-fix branch April 20, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants