embeds: support all youtube videos/urls, eliminate dependency on noembed, some other cleanup #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bed, some cleanup
patosullivan
force-pushed
the
po/tlon-3821-fix-youtube-embed-link-parsing-issue
branch
from
b9bb09c to
393db60
Compare
|
Cool, makes perfect sense to me. Is there a way to include the URL below the embedded video just in case the uploader prohibits playing from embeds or something else doesn't work? It's nice to be able to click through even if the in-app embed doesn't work for whatever reason. |
patosullivan
deleted the
po/tlon-3821-fix-youtube-embed-link-parsing-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTT, fixes tlon-3821
try using a
youtu.beurl, ahttps://youtube.com/shorts/url, or a/embedurl.Moved
trustedProvidersinto the embed module in shared, made theischecks for each provider use it, and added anisYouTubecheck so we don't have to rely on noembed at all anymore.