lib: Make sure that instance of mutate gets a unique id for each instate, fix #4218
#4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`instate` This is then used to check that mutations are performed within the same `instate` call, i.e., we cannot hide a mutation by just temporarily instating the corresponding `mutate` effect.
The spec says it should start with `1` and be incremented by `1`, so the new implementation does this using `AtomicLong`.
Once fixed, please verify the fix also works with the webserver before merging. I would like to avoid a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is then used to check that mutations are performed within the same
instatecall, i.e., we cannot hide a mutation by just temporarily instating the correspondingmutateeffect.Also add a regression test and fix the strange behavior of
fuzion.sys.misc.uniq_idwith the JVM backend.This currently breaks some code using
io.buffered.writethat needs to be checked.