tests: in negative.fz use $(FILE) instead of $(NAME)
#4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it clear with source file is loaded and avoides searching for source files. In particular, this also permits executable code in the universe of that source file, otherwise, it would be ambiguous when to execute that code. This revealed an error in `reg_issue4273` where the negative tests were ignored due to a type in the comments resulting in the lines that must fail not being found by `grep`.
maxteufel
added
build infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clear which source file is loaded and avoides searching for source files.
In particular, this also permits executable code in the universe of that source file, otherwise, it would be ambiguous when to execute that code.
This revealed an error in
reg_issue4273where the negative tests were ignored due to a typo in the comments resulting in the lines that must fail not being found bygrep.