lib: expanding_array.concat uses expand
#4766
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For certain clazzes, do not create ValueSet but, in case of a set, use one
global set for all sets.
- For cetain clazzes, do not create separate Instances depending on context, but
create only one single instance
- Do not create ValueSets of RefValue of the same clazz, but instead create
RefValue of ValueSet, i.e., instead of
{boxed(v1), boxed(v2)}
create
boxed({v1,v2})
All these can be enabled by static fields in DFA
static boolean ONLY_ONE_VALUE_SET = false;
static boolean ONLY_ONE_INSTANCE = false;
static boolean NO_SET_OF_REFS = false;
_universe is used only to hold fields of the universe.
First time I see HelloWorld <800ms
Many calls used to be created due to many different environments, even if effects form those different environments were never used. For a simle HelloWorld, this redecues the number of calls form 965 to 546. I expect a higher reduction for larger examples.
This currently results in endless runtime of DFA due to changes to `Sequence.concat`.
There are two possible traces at this point.
This should collapse environments that are essentially redundant for the desired call context. One big caveat: Recursive creation and instation of effects requires special handling to avoid endless recursion .
This was so far disabled since DFA could not handle this.
fridis
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still experimental since this depends on new DFA optimizations.