Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scripts for multi platform support #127

Merged
merged 2 commits into from
May 9, 2023
Merged

Added scripts for multi platform support #127

merged 2 commits into from
May 9, 2023

Conversation

pmorelli92
Copy link
Contributor

Solves #124

@jekiapp I modified the build.sh scripts so you can build locally the image targeting the usual amd/64, but when you want to push a release you can execute push.sh instead to push the same image, with the same version, on both amd/64 and arm/64.

I tried it on my docker account, and this is how it looks:
https://hub.docker.com/repository/registry-1.docker.io/pmorelli92/gripmock/tags?page=1&ordering=last_updated

Could you be kind enough to do us a favor an push the current release to be multi platform?

@pmorelli92
Copy link
Contributor Author

Hi @jekiapp any hope you can have a look at this?

@johnpawleysky
Copy link

@pmorelli92 has there been any traction on this? We may have to internally publish a version of this image unless this functionality is made available.

@pmorelli92
Copy link
Contributor Author

Hi @johnpawleysky I received no answer so far so I guess 0 traction. I did the code changes already, all we need is this to be merged and published tbh.

@johnpawleysky
Copy link

Hi @johnpawleysky I received no answer so far so I guess 0 traction. I did the code changes already, all we need is this to be merged and published tbh.

i've tried e-mailing their open source support line. Maybe that'll get some attention.

@jekiapp
Copy link
Contributor

jekiapp commented Dec 7, 2022

Hi sorry for the long reply, it's been a hectic month for me and our org.
Believe it or not, due to security reasons, it's been so hard to install things on the company laptop. It's embarrassing but, currently, I can't even compile proto (I'm working on it). And docker is also banned (seriously, it needs special requests).

@pmorelli92
Copy link
Contributor Author

Hi @jekiapp, any news regarding this?

@pmorelli92
Copy link
Contributor Author

Hello, any news on this?

@jekiapp jekiapp merged commit 69cfe84 into tokopedia:master May 9, 2023
@pmorelli92 pmorelli92 deleted the multi-platform branch May 9, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants