Remove concept of virtualization level #1648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But for a single place in test-db, we used virtualization level 0 for non-virtualized cells and level 1 for virtualized ones. With this patch, we do not store this level anymore and instead infer it based on "effective" level (previously known as VirtualizationParameters::level) and the actual level of the cell. This is mainly done to reduce cognitive complexity of the code. However, as a nice side-effect, changes in VirtualCell give a negligible performance improvement on the verification benchmark.
A well-known limitation of using ninja is that it requires the user to pass -fcolor-diagnostics=always flag to the compiler to get colored diagnostics. Starting from version 3.24, CMake can do this for us if we set CMAKE_COLOR_DIAGNOSTICS flag to truthful value.
DanShaders
force-pushed
the
virtualization-be-gone
branch
from
6c58028 to
0a2d87f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But for a single place in test-db, we used virtualization level 0 for non-virtualized cells and level 1 for virtualized ones. With this patch, we do not store this level anymore and instead infer it based on "effective" level (previously known as VirtualizationParameters::level) and the actual level of the cell.
This is mainly done to reduce cognitive complexity of the code. However, as a nice side-effect, changes in VirtualCell give a negligible performance improvement on the verification benchmark.