Skip to content

Highlight trailing whitespace #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alerque
Copy link

@alerque alerque commented Mar 8, 2016

This is a replacement for obsolete PR #52. The original poster has removed their fork and the issues raised in discussion there were never addressed.

This a) rebases the original commit on the current master and b) removes the hard coded color and replaces it with a link to the Error color.

I considered hiding this behind a feature flag, but wasn't sure what the demand would be. For me I can't see a need to not highlight these special meaning characters that are otherwise invisible, but if there is a demand for not having this I could put it behind a flag.

@tpope
Copy link
Owner

tpope commented Mar 8, 2016

I really don't like using Error for something that's not an error. Maybe Underlined or even Todo? Those are both visible for whitespace in the default color scheme.

@tpope
Copy link
Owner

tpope commented Mar 8, 2016

Or maybe we could set a conceal char. That feels like the most natural way to make it visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants