-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(candle): Allow enabling accelerate #1009
Conversation
a882676
to
92ca050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@louisfd can you check why the test fails on accelerate?
394aa36
to
2c7fb88
Compare
@louisfd @nathanielsimard I fixed the failing test on ---- tests::ad_transpose::tests::should_diff_swap_dims stdout ----
thread 'tests::ad_transpose::tests::should_diff_swap_dims' panicked at burn-candle/src/ops/tensor.rs:141:68:
called `Result::unwrap()` on an `Err` value: MatMulUnexpectedStriding(MatMulUnexpectedStriding { lhs_l: Layout { shape: [2, 2, 2], stride: [4, 2, 1], start_offset: 0 }, rhs_l: Layout { shape: [2, 2, 2], stride: [1, 2, 4], start_offset: 0 }, bmnk: (2, 2, 2, 2), msg: "non-contiguous rhs" }) I resolve this by making sure the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have tested on M3 Max and it's working.
Checklist
run-checks all
script has been executed.Related Issues/PRs
Fixes #968
Changes
Enables using accelerate for macOS
Testing
Tests have been run