Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/fusion/cache #1020

Merged
merged 25 commits into from
Dec 1, 2023
Merged

Feat/fusion/cache #1020

merged 25 commits into from
Dec 1, 2023

Conversation

nathanielsimard
Copy link
Member

First part, relative and global graph conversion and graph optimization cache!

Another level of caching is possible in the wgpu crate, but it will be done in a following PR.

Related Issues/PRs

Fix #935

@nathanielsimard nathanielsimard marked this pull request as draft November 30, 2023 02:47
@nathanielsimard nathanielsimard marked this pull request as ready for review November 30, 2023 20:21
louisfd
louisfd requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome.
There are many comments but most of them are typos in the doc.
There are a few which are more interesting though

burn-fusion/src/backend.rs Outdated Show resolved Hide resolved
burn-fusion/src/backend.rs Show resolved Hide resolved
burn-fusion/src/backend.rs Show resolved Hide resolved
burn-fusion/src/graph/base.rs Outdated Show resolved Hide resolved
burn-fusion/src/graph/base.rs Outdated Show resolved Hide resolved
burn-fusion/src/graph/path/base.rs Outdated Show resolved Hide resolved
burn-fusion/src/graph/path/base.rs Outdated Show resolved Hide resolved
burn-fusion/src/graph/path/base.rs Outdated Show resolved Hide resolved
burn-fusion/src/graph/path/base.rs Outdated Show resolved Hide resolved
burn-fusion/src/graph/path/base.rs Outdated Show resolved Hide resolved
@nathanielsimard nathanielsimard merged commit 670280d into main Dec 1, 2023
10 checks passed
@nathanielsimard nathanielsimard deleted the feat/fusion/cache branch December 1, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisfd louisfd louisfd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Burn-Fusion: Caching relative graphs
2 participants
@nathanielsimard @louisfd