Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 8.0 into 8 #919

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Merge 8.0 into 8 #919

merged 1 commit into from
Jan 14, 2025

Conversation

emteknetnz
Copy link
Contributor

@GuySartorelli
DEP Don't include vendor-plugin as an explicit dependency (#916)
b884b49 
We don't directly reference it in code or config, so we can rely on silverstripe/framework having this dependency for us.
@emteknetnz emteknetnz mentioned this pull request Jan 14, 2025
Open
GuySartorelli
GuySartorelli approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit ccf9141 into 8 Jan 14, 2025
19 checks passed
@GuySartorelli GuySartorelli deleted the 8.0 branch January 14, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli