Skip to content

Improve C++ legacy crypto algorithm query #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve C++ legacy crypto algorithm query #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81cac67
Improve C++ legacy crypto algorithm query
gsutherland-trailofbits Jul 16, 2025
1654fc8
Fix editing error in legacy cryptography algorithm query
gsutherland-trailofbits Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions cpp/src/crypto/UseOfLegacyAlgorithm.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,35 @@

import cpp

from FunctionCall call
from FunctionCall call, string functionName, string cipherName
where
call.getTarget()
.getQualifiedName()
.toLowerCase()
.matches([
// Hash functions
"%md2%", "%md4%", "%md5%", "%ripemd%", "%sha1%", "%whirlpool%", "%streebog%",
// KDFs
"%pbkdf1%",
// Symmetric ciphers
"%arcfour%", "%blowfish%", "%cast%", "%des%", "%idea%", "%kasumi%",
"%magma%", "%rc2%", "%rc4%", "%tdea%"
])
functionName = call.getTarget()
.getQualifiedName()
.toLowerCase()
and
(
exists(string cn |
cn in [
"MD2", "MD4", "MD5", "RIPEMD", "SHA1", "Whirlpool", "Streebog",
"PBKDF1",
"ArcFour", "Blowfish", "CAST", "IDEA", "Kasumi",
"Magma", "RC2", "RC4", "TDEA"
]
and cipherName = cn
and functionName.matches("%" + cn.toLowerCase() + "%")
)
/* match DES, but avoid false positives by not matching common terms containing it:
nodes
modes
codes
describe
description
descriptor
design
descend
destroy
*/
or cipherName = "DES" and functionName.regexpMatch(".*(?<!no|mo|co)des(?!cri(be|ption|ptor)|ign|cend|troy).*")
)
select call.getLocation(),
"Potential use of legacy cryptographic algorithm " + call.getTarget().getQualifiedName() +
" detected"
"Potential use of legacy cryptographic algorithm " + cipherName + " detected in function name " + call.getTarget().getQualifiedName()
Loading