Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add GitHub Actions workflow for testing #437

Merged
merged 1 commit into from
May 25, 2024
Merged

ci: add GitHub Actions workflow for testing #437

merged 1 commit into from
May 25, 2024

Conversation

hamirmahal
Copy link
Contributor

closes #436.

Problem

We can't tell if a change breaks tests without cloning changes locally.

How this change fixes it

CI automatically checks if tests pass, for us.

@vitonsky
Copy link
Collaborator

Oh i forgot we even no have tests on CI for this project. Nice work!

Btw, as i see CodeQL did not runned for this PR. Maybe because we no have changes in code (ts/js files).
Anyway, it means we have to setup CI analysis for non-code files. Any files that may affect on code execution must be analyzed, including workflow files

@vitonsky vitonsky merged commit cedd7b3 into translate-tools:master May 25, 2024
1 check passed
@hamirmahal hamirmahal deleted the ci/test-in-github-actions branch May 25, 2024 21:22
@hamirmahal
Copy link
Contributor Author

Oh i forgot we even no have tests on CI for this project. Nice work!

Thanks!

Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, as i see CodeQL did not runned for this PR. Maybe because we no have changes in code (ts/js files). Anyway, it means we have to setup CI analysis for non-code files. Any files that may affect on code execution must be analyzed, including workflow files

It looks like the CodeQL check automatically ran on the commit merged into the main branch.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check if tests pass with a change
2 participants