-
-
Notifications
You must be signed in to change notification settings - Fork 797
New jump to parent or root run buttons #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f389ead
5e2aa4d
05a0f4f
a22e189
ec9131b
fe0055f
6f4d713
cf41072
35a9e41
0e0b8d7
b5c1df7
be5ca8b
fb91c87
19e8673
9626eb6
d588031
6e99c58
de5fc66
93954ce
6e78f23
ef3699c
93e68e4
5b9497d
e0706e8
e436368
300641f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
export function MoveToTopIcon({ className }: { className?: string }) { | ||
return ( | ||
<svg className={className} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
<g clipPath="url(#clip0_17186_103975)"> | ||
<path | ||
d="M12 21L12 9" | ||
stroke="currentColor" | ||
strokeWidth="2" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
/> | ||
<path | ||
d="M3 3L21 3" | ||
stroke="currentColor" | ||
strokeWidth="2" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
/> | ||
<path | ||
d="M16.5 11.5L12 7L7.5 11.5" | ||
stroke="currentColor" | ||
strokeWidth="2" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
/> | ||
</g> | ||
<defs> | ||
<clipPath id="clip0_17186_103975"> | ||
<rect width="24" height="24" fill="currentColor" /> | ||
</clipPath> | ||
</defs> | ||
</svg> | ||
); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
export function MoveUpIcon({ className }: { className?: string }) { | ||
return ( | ||
<svg className={className} viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
<g clipPath="url(#clip0_17177_110851)"> | ||
<path | ||
d="M12 21L12 13" | ||
stroke="currentColor" | ||
strokeWidth="2" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
/> | ||
<path | ||
d="M3 3L21 3" | ||
stroke="currentColor" | ||
strokeWidth="2" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
/> | ||
<path | ||
d="M3 7L21 7" | ||
stroke="currentColor" | ||
strokeWidth="2" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
/> | ||
<path | ||
d="M16.5 15.5L12 11L7.5 15.5" | ||
stroke="currentColor" | ||
strokeWidth="2" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
/> | ||
</g> | ||
<defs> | ||
<clipPath id="clip0_17177_110851"> | ||
<rect width="24" height="24" fill="currentColor" /> | ||
</clipPath> | ||
</defs> | ||
</svg> | ||
); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import { millisecondsToNanoseconds } from "@trigger.dev/core/v3"; | ||
import { createTreeFromFlatItems, flattenTree } from "~/components/primitives/TreeView/TreeView"; | ||
import { prisma, PrismaClient } from "~/db.server"; | ||
import { prisma, type PrismaClient } from "~/db.server"; | ||
import { createTimelineSpanEventsFromSpanEvents } from "~/utils/timelineSpanEvents"; | ||
import { getUsername } from "~/utils/username"; | ||
import { eventRepository } from "~/v3/eventRepository.server"; | ||
|
@@ -58,7 +58,13 @@ export class RunPresenter { | |
rootTaskRun: { | ||
select: { | ||
friendlyId: true, | ||
taskIdentifier: true, | ||
spanId: true, | ||
createdAt: true, | ||
}, | ||
}, | ||
parentTaskRun: { | ||
Comment on lines
+61
to
+65
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainRoot/parent selections updated; confirm no lingering uses of removed taskIdentifier/parentRunFriendlyId Selections and returned shape look correct for new consumers. Please verify no remaining code paths still read Run from repo root: Also applies to: 66-71, 120-121 🏁 Script executed: #!/bin/bash
# Check for removed fields usage
rg -nP -C2 '\b(rootTaskRun|parentTaskRun)\.taskIdentifier\b|parentRunFriendlyId\b' Length of output: 460 Remove lingering parentRunFriendlyId usage 🤖 Prompt for AI Agents
|
||
select: { | ||
friendlyId: true, | ||
spanId: true, | ||
createdAt: true, | ||
}, | ||
|
@@ -111,6 +117,7 @@ export class RunPresenter { | |
completedAt: run.completedAt, | ||
logsDeletedAt: showDeletedLogs ? null : run.logsDeletedAt, | ||
rootTaskRun: run.rootTaskRun, | ||
parentTaskRun: run.parentTaskRun, | ||
environment: { | ||
id: run.runtimeEnvironment.id, | ||
organizationId: run.runtimeEnvironment.organizationId, | ||
|
@@ -202,8 +209,6 @@ export class RunPresenter { | |
trace: { | ||
rootSpanStatus, | ||
events: events, | ||
parentRunFriendlyId: | ||
tree?.id === traceSummary.rootSpan.id ? undefined : traceSummary.rootSpan.runId, | ||
duration: totalDuration, | ||
rootStartedAt: tree?.data.startTime, | ||
startedAt: run.startedAt, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid conditional hook calls – they break the Rules of Hooks
useShortcutKeys
is invoked only whenshortcut
is truthy.If the component first renders with
shortcut={undefined}
and later re-renders with a shortcut the hook order will change, throwingInvariant Violation: Rendered fewer hooks than expected
.Unconditionally call the hook and gate the feature inside the hook’s own options instead:
🤖 Prompt for AI Agents